Skip to content

Patch jar check #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

Patch jar check #337

merged 4 commits into from
Jul 7, 2025

Conversation

bxngyn
Copy link
Contributor

@bxngyn bxngyn commented Jul 1, 2025

Related to issue #332.

Added a check for the 4 specific test_() functions and file line length. Obviously, line length checks can be easily exploited by things like comments, and the limit of 20 lines is pretty arbitrary (I based it off of a minimal implementation of what the spec said to do for test_jar.py). However, scanning the file for specific assertions that align with the spec seemed excessive, so just thought I'd go this path.

@bxngyn bxngyn requested review from rongxin-liu and ivanharvard July 1, 2025 20:15
@rongxin-liu rongxin-liu self-assigned this Jul 1, 2025
@rongxin-liu rongxin-liu added enhancement New feature or request CS50P CS50 Python labels Jul 1, 2025
@rongxin-liu
Copy link
Contributor

@bxngyn Looks good overall! I made some changes.

@rongxin-liu rongxin-liu merged commit 0df91b4 into 2022/python Jul 7, 2025
@rongxin-liu rongxin-liu deleted the patch-jar-check branch July 7, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CS50P CS50 Python enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants